jetty / jetty/jetty.project

EE1 TCK failure: async dispatch using `ServletRequestWrapper` and `ServleResponseWrapper`

Open
#13,397 0 comments 0 reactions 1 assignee Claimed by @janbartel View on GitHub
Bug TCK
Dominant language
Java
Stars
4.1k
Forks
2k
Avg merge
3d 56m
Merged PRs (30d)
48

Description

**12.1.x**

The following TCK tests fail:

- `servlet.tck.api.jakarta_servlet.asynccontext.AsyncContextTests.dispatchZeroArgTest2`
- `servlet.tck.api.jakarta_servlet.asynccontext.AsyncContextTests.dispatchContextPathTest2`

This test does:

```java
AsyncContext ac = request.startAsync(new RequestWrapper(request),
new ResponseWrapper(response));
```

where `RequestWrapper` and `ResponseWrapper` are `ServletRequestWrapper` and `ServletResponseWrapper`s.

This means that the request/response pair that is async dispatched is _not_ a `HttpServletRequest` and `HttpServletResponse`.

In this case, Jetty's implementation is to try to wrap the `ServletRequest` and `ServletResponse` in a `o.e.j.eeN.servlet.ServletRequestHttpWrapper` and a `o.e.j.eeN.servlet.ServletResponseWrapper` - the implementation of which is to always throw `UnsupportedOperationException`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.