jessepollak / jessepollak/card

Credit Card with RTL the float:right makes a problem

Open
#538 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
SCSS
Stars
11.7k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

Hello everyone,
Thanks for your efforts,
I have a problem with the module when the direction of the page get rtl,
the float:right in .jp-card .jp-card-front .jp-card-lower .jp-card-expiry,
because the name also comes in the right,
I tried this but didn't work in chrome:
.jp-card .jp-card-front .jp-card-lower .jp-card-expiry[direction="rtl"] {
float: left
}

what could be the solution?

Contributor guide

Open the contributing guide

Research direction

Start with the .jp-card .jp-card-front .jp-card-lower .jp-card-expiry styles and reproduce the RTL layout problem in Chrome. Check how the card handles page direction and verify that the expiry area and cardholder name are positioned correctly when the page is RTL.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.