jessepollak / jessepollak/card

Formatting

Open
#436 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
SCSS
Stars
11.7k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

Hi, firstly thank you for this nice credit card form.

My issue is when I chose a saved credit card (on browser) the value that get submitted is formatted "xxxx xxxx xxxx xxxx" so it generate error (I tried to remove the space (reformat) using a jquery with multiple methods without touching card.js but the last value of the card number is always formatted), so when I turn off formatting "formatting: false", the card doesn't detect the card type (visa..)

I hope you get what I mean ^^

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the saved-credit-card browser flow described in the issue with card.js, comparing formatting enabled with formatting: false. Check the submitted card-number value and card-type detection; done means saved-card submissions are accepted without spaces while card type detection still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend, payments
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.