jessepollak / jessepollak/card

Scale on small devices are increasing size instead of decreasing

Open
#262 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
SCSS
Stars
11.7k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

When the width is set and card opened on mobile device in interactive mode the card image take a LOT of space.
Basically
https://github.com/jessepollak/card/blob/2b20e8b2514f3084c476fc54ac4a8bc18412291a/src/coffee/card.coffee#L133

@options.width / baseWidth

when baseWidth e.g. clientWidth is lesser than card width the scale will be larger than 1.
And i guess it should be vice versa e.g.
baseWidth / @options.width

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.