jesseduffield / jesseduffield/lazygit
Should GIT_EDITOR and GIT_SEQUENCE_EDITOR have quoted values?
- Dominant language
- Go
- Stars
- 82.4k
- Forks
- 3k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 19
Description
I was checking git hooks and noticed that GIT_EDITOR and GIT_SEQUENCE_EDITOR for post-checkout hook during rebase contain quoted path to lazygit, so they are not printed by env to be:
```env
GIT_SEQUENCE_EDITOR=/opt/local/bin/lazygit
GIT_EDITOR=/opt/local/bin/lazygit
```
but rather:
```env
GIT_SEQUENCE_EDITOR="/opt/local/bin/lazygit"
GIT_EDITOR="/opt/local/bin/lazygit"
```
Is this correct behaviour?
Contributor guide
Research direction
Start with the post-checkout hook during rebase and inspect how GIT_EDITOR and GIT_SEQUENCE_EDITOR are set before checking their values with env. Compare the quoted and unquoted forms, then establish whether the behavior is intentional; done means resolving the question with the appropriate behavior verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100