jesseduffield / jesseduffield/lazygit
Local commits tab get visually stuck when doing rename in editor with neovim
- Dominant language
- Go
- Stars
- 82.4k
- Forks
- 3k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 19
Description
### Describe the bug
I use neovim with lazygit, and I often prefer to do by renames in my editor instead of inside of lazygit.
This operation frequently results in my local commits tab visually getting stuck in an interactive rebase state (See below screenshot).
This bug seems to be particularly worse when dealing with further back commits, making me think it is something wrong to do with the timing of lazygit's refresh once you return to it. Screenshot below shows the stuck state.
### To Reproduce
Pre-requisites:
* Use `kdheepak/lazygit.nvim` plugin for neovim
* Use nvim 0.11.2 (I haven't tested any other versions, but that's what I am using)
* Have the lazygit setting:
```
os:
editPreset: 'nvim-remote'
```
Steps to reproduce the behavior:
1. Launch nvim
2. Launch lazygit with `:LazyGit` from lazygit plugin
3. Press `4` to go to local commits tab and scroll back ~30 commits
4. Press `R` to reword in editor
5. Press `` to accept warning of rewording in editor
6. Observe that git commit message editor pops up
7. Make some changes to the commit message
8. Press `:wq` to save changes and quit editor
9. Observe that lazygit returns to the foreground
10. See that Commits window is still visually stuck in interactive rebase mode (See below screenshot)
11. Press `4` `m` `c` to tell lazygit to continue the nonexistant rebase. It will tell you there is no active rebase, and you will click enter to exit this popup. (This is my current workaround)
### Expected behavior
I expect LazyGit to be spinning for a little bit while the interact rebase finishes, just like when renaming commits with `r`, and to eventually indicate that the interactive rebase is finished.
### Screenshots
See panel 4 for the visual bug:
### Version info:
* _Run `lazygit --version` and paste the result here_
0.54.2 (but also validated against latest master `be0d7a6e7358`
* _Run `git --version` and paste the result here_
git version 2.51.0
### Additional context
I imagine this is likely something in the interaction between nvim-remote, kdheepak/lazygit.nvim, and lazygit, which might make it totally unsolvable on the lazygit side. I shall continue investigating!
This bug also does not occur when lazygit is not inside of nvim. If I launch lazygit directly in my terminal, press `R` to reword, and then go back to lazygit, I see a `Rebasing (1/300)` counter in my terminal that holds me in my terminal until the operation finishes. When I then "Press enter to return to lazygit", it is in a happy state.
Contributor guide
Assessment
This issue has not been assessed yet.