jesseduffield / jesseduffield/lazygit
Commits scrollbar cut by icon
- Dominant language
- Go
- Stars
- 82.4k
- Forks
- 3k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 19
Description
**Describe the bug**
When an icon appears as the last character on the commit tab (probably others too), the scrollbar is cut. See attached screenshots.
**To Reproduce**
Steps to reproduce the behavior:
1. Open any git repo with icons ([ratatui main](https://github.com/ratatui-org/ratatui/) has recent commits with icons)
2. If needed, adjust the size of the terminal/pane so that the icon is the last shown character
**Expected behavior**
The scrollbar should always be visible. The icon hidden or shown as needed.
**Screenshots**
lazygit on alacritty

lazygit on xfce4-terminal

When the handle is aligned with the icon

**Version info:**
```sh
$ lazygit --version
commit=5e388e21c8ca6aa883dbcbe45c47f6fdd5116815, build date=2023-08-07T14:05:48Z, build source=binaryRelease, version=0.40.2, os=linux, arch=amd64, git version=2.34.1
$ git --version
git version 2.34.1
```
**Additional context**
That's really not disturbing or anything, but still a bug. Your call if you think it's a necessary fix.
It's very likely this is due to icons being multibytes.
Otherwise Lazygit is great, thank you!
**Note:** please try updating to the latest version or [manually building](https://github.com/jesseduffield/lazygit/#manual) the latest `master` to see if the issue still occurs.
I'd like to avoid building from main as I don't have the go tooling installed. But if that's really necessary just tell me.
Contributor guide
Assessment
This issue has not been assessed yet.