jesseduffield / jesseduffield/lazygit

Use editor defined in `EDITOR` environment variable instead of `vim`

Open
#2,624 8 comments 4 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
82.4k
Forks
3k
Avg merge
2d 18h
Merged PRs (30d)
19

Description

Some versions ago editor from `EDITOR` environment variable was used. But this were broken in latest versions (#2576). Currently it seems that editor should be already known (`editor_presets.go`) or defined in `config.yml`.

Better to use editor in `EDITOR` environment variable with default preset:
```
func standardTerminalEditorPreset(editor string) *editPreset {
return &editPreset{
editTemplate: editor + " -- {{filename}}",
editAtLineTemplate: editor + " +{{line}} -- {{filename}}",
editAtLineAndWaitTemplate: editor + " +{{line}} -- {{filename}}",
editInTerminal: true,
}
}
```
For example, `EDITOR=mcedit` works great with standard terminal editor preset, including line numbers.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.