jesseduffield / jesseduffield/lazygit

Incorrect UI state when bring up help within certain sub commands

Open
#2,129 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
82.4k
Forks
3k
Avg merge
2d 18h
Merged PRs (30d)
19

Description

**Describe the bug**
When brining up the help menu from a few sub commands like the custom command history window or the rename branch window the UI gets into an incorrect state, leaving the sub window up over the help menu, and after escaping from help menu the sub window stays open and lazygit behaves incorrectly.

**To Reproduce**
Steps to reproduce the behavior:

1. Bring up the execute custom command window (key ':')
2. Press tab key to go to suggestions panel
3. Bring up help (key '?')
4. Notice the help menu is opened but the custom commands window stays open on top
5. Close the help window (key: 'esc')
6. Notice we stay in the suggestions window but nothing is functional and cannot do any other than quit lazygit

Also so far found same issue with gitflow options, rebase and rename branch, possibly other commands also have the issue.
**Expected behavior**
Either the subwindow should close when help comes up or the help should be disabled during subwindow command.

**Screenshots**
![image](https://user-images.githubusercontent.com/2026043/185940197-42162316-7bc5-42f3-886d-317238b818e6.png)

![image](https://user-images.githubusercontent.com/2026043/185941099-0d78e02e-9efb-45a3-8639-5e13d571b823.png)

![image](https://user-images.githubusercontent.com/2026043/185941270-5f15b8a3-0959-478e-b982-fd4a20986250.png)

![image](https://user-images.githubusercontent.com/2026043/185941389-64838754-b19e-4d85-8527-b4c981fa1c23.png)

**Version info:**
`lazygit --version`: commit=367b0d331836c90c015bf0c45f88612f3d94d08a, build date=2022-07-20T09:27:56Z, build source=binaryRelease, version=0.35, os=linux, arch=amd64

`git --version`: git version 2.34.1

**Additional context**
Issue is also on current master.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.