jesseduffield / jesseduffield/lazygit
Still seeing errors when using delta
- Dominant language
- Go
- Stars
- 82.4k
- Forks
- 3k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 19
Description
**Describe the bug**
I get panics when using delta as a pager.
Specifically ones like this one:
```
panic: runtime error: index out of range [3] with length 3
goroutine 198 [running]:
github.com/jesseduffield/gocui.(*escapeInterpreter).outputTrue(0xc000232640)
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/escape.go:304 +0x430
github.com/jesseduffield/gocui.(*escapeInterpreter).parseOne(0xc000232640, 0x34)
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/escape.go:166 +0x428
github.com/jesseduffield/gocui.(*View).parseInput(0xc000246b40, 0x6d)
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/view.go:667 +0x45
github.com/jesseduffield/gocui.(*View).writeRunes(0xc000246b40, {0xc000562000, 0x7d, 0x38})
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/view.go:638 +0x15a
github.com/jesseduffield/gocui.(*View).Write(0xc000246b40, {0xc0002a8437, 0x7d, 0x0})
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/view.go:606 +0xe6
github.com/jesseduffield/lazygit/pkg/tasks.(*ViewBufferManager).NewCmdTask.func1.4()
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/tasks/tasks.go:182 +0x24b
github.com/jesseduffield/lazygit/pkg/utils.Safe.func1()
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/utils/utils.go:95 +0x1b
github.com/jesseduffield/lazygit/pkg/utils.SafeWithError(0x43e9c5)
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/utils/utils.go:106 +0x67
github.com/jesseduffield/lazygit/pkg/utils.Safe(0x0)
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/utils/utils.go:95 +0x35
created by github.com/jesseduffield/lazygit/pkg/tasks.(*ViewBufferManager).NewCmdTask.func1
/home/me/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/tasks/tasks.go:151 +0x645
```
**To Reproduce**
I am not entirely sure how to reproduce. It mostly happens when seeing diffs for commits, less so when staging changes.
My configs look like this:
lazygit:
```
git:
pull:
mode: 'auto'
overrideGpg: true
paging:
colorArg: always
pager: delta --dark --paging=never
services:
'git.rtx.mapspeople.com': 'gitlab:git.rtx.mapspeople.com'
```
And git:
```
[user]
name = Mikael Elkiaer
email = 2102306+MikaelElkiaer@users.noreply.github.com
[includeIf "gitdir:**/Repositories/GitHub/**"]
path = ~/.gitconfig-github
[includeIf "gitdir:**/Repositories/MapsPeople/**"]
path = ~/.gitconfig-mapspeople
[includeIf "gitdir:**/Repositories/AUR/**"]
path = ~/.gitconfig-aur
[core]
autocrlf = input
editor = nvim
pager = delta --dark
[interactive]
diffFilter = delta --dark --color-only
[rebase]
autosquash = true
[credential]
helper = cache
[pull]
rebase = true
[merge]
ff = false
tool = vimdiff
[push]
default = current
[alias]
{...}
[color]
ui = auto
[diff]
tool = vimdiff
[advice]
addIgnoredFile = false
```
**Expected behavior**
Expected it to work, as it had done previously.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- `lazygit -v` outputs `commit=d0196263, build date=20220117.112305, build source=unknown, version=v0.32.1.d0196263, os=linux, arch=amd64`
- Running on Manjaro i3 edition
**Additional context**
Add any other context about the problem here.
Contributor guide
Assessment
This issue has not been assessed yet.