jesseduffield / jesseduffield/lazygit

Pop-up windows don't disable irrelevant key mappings

Open
#1,628 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
82.4k
Forks
3k
Avg merge
2d 18h
Merged PRs (30d)
19

Description

**Describe the bug**
Pop-up windows don't disable shortcuts, e.g. the prompt `Are you sure you want to quit?` allows me to press `z` and trigger `undo`. Or even press `x` to bring up the menu.

**To Reproduce**
Steps to reproduce the behavior:
1. Set `confirmOnQuit: true` in your config
2. Press `q` in `lazygit`
3. Press `x` or `z`
4. It does the action that the key is mapped to

**Expected behavior**
Pressing things not relevant to the pop-up shouldn't do anything

**Screenshots**
![image](https://user-images.githubusercontent.com/8365241/146534822-e69fa57c-6ddb-4821-86b1-0140b58e1325.png)

**Desktop (please complete the following information):**
- OS: archlinux
- Lazygit Version 0.31.4
- The last commit id if you built project from sources: N/A

**Additional context**
The reason I press `z` instead of `y` when quitting is because I often switch between two keyboard layouts and forget what's the current one I'm using.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.