jesseduffield / jesseduffield/lazygit
Crash when clicking "Ask question" link on ssh connection
- Dominant language
- Go
- Stars
- 82.4k
- Forks
- 3k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 19
Description
**Describe the bug**
lazygit crashed in the following situation:
I have windows terminal open, and I connected to a linux machine using ssh.
In that machine I opened lazygit and clicked "Ask question" link.
After that lazygit crashed.
**To Reproduce**
Steps to reproduce the behavior:
1. Open ubuntu on windows terminal (no X forwarding)
2. Click on "Ask question link"
3. See additional context bellow
**Expected behavior**
Simply ignore click if link cannot be displayed
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: Windows 10 + Windows terminal + Ubuntu on WSL 1
- Lazygit Version: 0.29
**Additional context**
2021/10/14 11:43:52 An error occurred! Please create an issue at: https://github.com/jesseduffield/lazygit/issues
*errors.errorString exo-open: Cannot open display: .
xdg-open: no method available for opening 'https://github.com/jesseduffield/lazygit/discussions'
/home/runner/work/lazygit/lazygit/pkg/commands/oscommands/os.go:296 (0x695b8f)
/home/runner/work/lazygit/lazygit/pkg/commands/oscommands/os.go:173 (0x69492c)
/home/runner/work/lazygit/lazygit/pkg/commands/oscommands/os.go:261 (0x6960ea)
/home/runner/work/lazygit/lazygit/pkg/commands/oscommands/os.go:261 (0x6960b4)
/home/runner/work/lazygit/lazygit/pkg/gui/information_panel.go:49 (0x9e1112)
/home/runner/work/lazygit/lazygit/pkg/gui/confirmation_panel.go:314 (0xa26be6)
/home/runner/work/lazygit/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:1170 (0x686fc5)
/home/runner/work/lazygit/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:1138 (0x686bb1)
/home/runner/work/lazygit/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:1099 (0x686906)
/home/runner/work/lazygit/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:654 (0x684a86)
/home/runner/work/lazygit/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:636 (0x684995)
/home/runner/work/lazygit/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:622 (0x6846cc)
/home/runner/work/lazygit/lazygit/pkg/gui/gui.go:523 (0x9df43b)
/home/runner/work/lazygit/lazygit/pkg/gui/gui.go:531 (0xa2c7c5)
/home/runner/work/lazygit/lazygit/pkg/utils/utils.go:126 (0x691082)
/home/runner/work/lazygit/lazygit/pkg/gui/gui.go:530 (0x9df7bd)
/home/runner/work/lazygit/lazygit/pkg/app/app.go:240 (0xa49f8b)
/home/runner/work/lazygit/lazygit/main.go:127 (0xa4b8fb)
/opt/hostedtoolcache/go/1.16.7/x64/src/runtime/proc.go:225 (0x4389d6)
/opt/hostedtoolcache/go/1.16.7/x64/src/runtime/asm_amd64.s:1371 (0x46c5e1)
Contributor guide
Assessment
This issue has not been assessed yet.