jesseduffield / jesseduffield/lazygit

GPG signing breaks commit flow

Open
#1,146 11 comments 37 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
82.4k
Forks
3k
Avg merge
2d 18h
Merged PRs (30d)
19

Description

**Describe the bug**
When signing commits with a GPG key (which is unlocked, but password protected), Lazygit gets booted out to a shell and prompts pressing enter to return to Lazygit.

**To Reproduce**
Steps to reproduce the behavior:
1. Setup GPG signing (I have a passworded key in this example)
2. Setup auto signing with `git config --global commit.gpgsign true`
3. Make a commit via Lazygit
4. Booted out of UI and have to press enter to return to Lazygit: https://github.com/jesseduffield/lazygit/blob/master/pkg/i18n/english.go#L823

Output when booted out:
```
➜ linux-scripts git:(master) ✗ lazygit

+ bash -c git commit -m "test: remove file"

[master 7e90dc1] test: remove file
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 test

Press enter to return to lazygit
➜ linux-scripts git:(master)
```

**Expected behavior**
Make the commit. Do not close the UI, do require pressing enter. Do not pass go :-)

**Desktop:**
- OS: Pop!_OS (Ubuntu)
- Lazygit Version: 0.23.2

**Additional context**
Maybe related to #30

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.