jesseduffield / jesseduffield/lazygit

Minor wording inconsistency: Confirmation prompts

Open
#1,111 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Go
Stars
82.4k
Forks
3k
Avg merge
2d 18h
Merged PRs (30d)
19

Description

When I push a branch that I've rebased, then I get a popup telling me that there is a problem, and that I can use 'enter' to force-push, or 'esc' to cancel.

When I rebase the current branch onto another branch, I get a popup asking me whether I'm sure. I can use 'enter' or 'y' to confirm (haven't tried any other keys) and 'esc' to abort (haven't tried 'n' yet).

I feel these two situations are quite similar, and essentially both of these are confirmation dialogs. I feel that either both should tell me which keys to use, or neither.

My personal preference would be a suffix that indicates which keys are possible:

```
Are you sure you want to do this? [Y/n]
```

The square brackets would list the possible answers, and the uppercase letter indicates which one is the default (i.e. used when hitting enter).

Or there is a dialog that includes actual buttons and tab is used to navigate between them, but maybe that's more effort than just rewording the string...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.