jesseduffield / jesseduffield/lazydocker
Improve Podman support: Removing containers does not use commandTemplates
- Dominant language
- Go
- Stars
- 52.8k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I've tried to customize my environment to support Podman, and it partially works, but some commands seems to be hard coded and is not possible to customize.
When deleting a container with compose it tries to run the command `{{ .DockerCompose }} rm --stop --force hello_world` which will fail with the error `podman-compose: error: argument command: invalid choice: 'rm'`
podman-compose does not have the `rm` option, so i tried to change the `commandTemplates.down` and `commandTemplates.downWithVolumes` configuration option, but that does not seem to have any effect.
I managed to locate the code where it runs the command:
https://github.com/jesseduffield/lazydocker/blob/06ab7b77b1e0646743eda6cba4a0936efc97aa5b/pkg/gui/services_panel.go#L156
https://github.com/jesseduffield/lazydocker/blob/06ab7b77b1e0646743eda6cba4a0936efc97aa5b/pkg/gui/services_panel.go#L160
I have not checked if there are other places that also has this problem, but using commandTemplates would be a important improvement for supporting Podman.
Running lazydocker version 0.23.3 on NixOS.
Contributor guide
Assessment
This issue has not been assessed yet.