jesseduffield / jesseduffield/lazydocker

Use a home-based path for the Linux installation script

Open
#270 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
52.8k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
The current Linux-installation script requires sudo-rights, and it places the file into the `/usr/local/bin`. This is not really necessary, since a user could also just install the script in `~/.local/bin` without sudo-rights.

Since users don't have any managed way to update this script, I would recommend against placing it in the system folder, as it might cause issues in the future. Besides, piping curl and bash is a bad practice and forcing users to do so with sudo-rights is even more dangerous.

**Describe the solution you'd like**
I would change the installation script and install to `~/.local/bin` by default

**Describe alternatives you've considered**
You could make a script-based switch: Sudo-rights: yes, install in `/usr/local/bin`. no, install in `~/.local/bin`. I would opt against this though, since it would still encourage sudo-curl-bash piping.

**Additional context**

Security discussion pages:
- https://blog.dijit.sh//don-t-pipe-curl-to-bash
- https://www.arp242.net/curl-to-sh.html
- and many more, but let's not digress

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.