jerpint / jerpint/woltspace

Orphaned livereload process after wolt dir is manually deleted

Open
#321 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
12
Forks
1
Avg merge
7h 13m
Merged PRs (30d)
31

Description

Bug

When a wolt directory is manually deleted (e.g. `rm -rf wolts/demonightwolt`), the livereload process for that wolt keeps running and holds its assigned port. The `.state/` directory (which lives outside the wolt dir) is not cleaned up either.

This causes port collisions for newly created wolts that get assigned the same port number.

Steps to reproduce

  1. Create a wolt (e.g. `demonightwolt`) — livereload starts on e.g. port 6009
  2. Manually `rm -rf wolts/demonightwolt` without going through any API
  3. Create a new wolt that gets assigned port 6009
  4. New wolt's site fails to serve — old process is still bound to 6009

Root cause

  • `stop_site()` in `sites.py` only clears the state file — it does not kill the process (no PID stored)
  • `get_site_state()` checks liveness by TCP connect, so a process serving a deleted wolt's files on the port still looks alive
  • When a wolt dir is deleted manually, nothing signals the server to kill its livereload process or reclaim its port

Possible fixes

  • On server startup, scan `.state/site.json` files and kill + clear any whose wolt dir no longer exists
  • Store PID in state file so `stop_site()` can actually kill the process
  • Add a wolt deletion API endpoint that tears down the site before removing files

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in sites.py and inspect the .state/site.json lifecycle, especially stop_site() and get_site_state(). Reproduce the issue by deleting a wolt directory manually, then verify that its livereload process is stopped, its state is cleared, and the port can be reused by a newly created wolt.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.