jeremydaly / jeremydaly/lambda-api

Typescript type for rawBody doesn't align with APIGatewayProxyEventBase body

Open
#209 1 comment 0 reactions 1 assignee View on GitHub

@naorpeled is already working on this.

Since Dec 20, 2022.

Dominant language
JavaScript
Stars
1.5k
Forks
127
Avg merge
31m
Merged PRs (30d)
2

Description

The REQUEST.rawBody is the same as the lambda event body which should be string | null but is defined as string in the type definition.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/trigger/api-gateway-proxy.d.ts#L117

https://github.com/jeremydaly/lambda-api/blob/main/index.d.ts#L146

Can it be updated to match? I'm happy to raise pull request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.