jenssegers / jenssegers/agent

Wrong mobile detection

Open
#210 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
4.9k
Forks
545
PR merge metrics
No merged PRs in 30d

Description

Runs v2.6.4 on MacBook Pro (Chrome) - UserAgent `Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36` the methods `agent->isPhone()` and `agent->isMobile()` returns `true`
while `agent->isDesktop()` returns false.

![image](https://github.com/jenssegers/agent/assets/42751239/c4c8ce15-ddbe-4e41-aff4-a339b50f8e91)
![image](https://github.com/jenssegers/agent/assets/42751239/5b6d8c4b-6bb5-4be0-98d9-7510fac2a0d6)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the report with the supplied Chrome-on-macOS user agent, then trace the implementations of agent->isPhone(), agent->isMobile(), and agent->isDesktop(). Check the existing user-agent detection tests, if present, and add coverage for this string; done means desktop is detected while phone and mobile are false.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.