jenkinsci / jenkinsci/workflow-durable-task-step-plugin
[JENKINS-51010] Batch step marked as succeeded when set to return a non-zero value
- Dominant language
- Java
- Stars
- 46
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
When I use returnStatus I get the return code, but the bat step itself doesn't show as failed in the Pipeline Steps page. Consider the following example:
node {
stage ('example') {
int rc = bat([script: 'exit 1', returnStatus: true])
if (rc) {
println 'Failed!'
{{ }}}
else {
println 'Success!'
{{ }}}
{{ }}}
}
This is the output of the build:
Started by user anonymous
Running in Durability level: MAX_SURVIVABILITY
[Pipeline] node
Running on Jenkins in D:\Jenkins\workspace\bat
[Pipeline] {
[Pipeline] stage
[Pipeline] { (example)
[Pipeline] bat
[bat] Running batch script
D:\Jenkins\workspace\bat>exit 1
[Pipeline] echo
Failed!
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS
This is expected, but as you can see the batch script step itself isn't marked as failed:

---
Originally reported by
towel, imported from: Batch step marked as succeeded when set to return a non-zero value
Raw content of original issue
When I use returnStatus I get the return code, but the bat step itself doesn't show as failed in the Pipeline Steps page. Consider the following example:
node {
stage ('example') {
int rc = bat([script: 'exit 1', returnStatus: true])
if (rc) {
println 'Failed!'
{{ }}}
else {
println 'Success!'
{{ }}}
{{ }}}
}
This is the output of the build:
Started by user anonymous
Running in Durability level: MAX_SURVIVABILITY
[Pipeline] node
Running on Jenkins in D:\Jenkins\workspace\bat
[Pipeline] {
[Pipeline] stage
[Pipeline] { (example)
[Pipeline] bat
[bat] Running batch scriptD:\Jenkins\workspace\bat>exit 1
[Pipeline] echo
Failed!
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESSThis is expected, but as you can see the batch script step itself isn't marked as failed:
environment
```
Windows Server 2016 (Jenkins master)
Jenkins 2.107.2 LTS
Pipeline: Nodes and Processes 2.19
```
1 attachment
- [Untitled.png](https://issues.jenkins.io/secure/attachment/42315/Untitled.png)
> 
Contributor guide
Assessment
This issue has not been assessed yet.