jenkinsci / jenkinsci/violation-comments-to-github-plugin

Comment only changed files: commented on some_file.py when the error affected file.py

Open
#33 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
25
Forks
12
PR merge metrics
No merged PRs in 30d

Description

The PR contained multiple files, among them was folder1/folder2/some_file.py
The plugin commented about file.py (which is in the base of the repo, not in any folder), although the file was not changed in the PR.
It seems the same postfix ("file.py") confused the "Comment only changed files" feature.

**Plugin version** 1.84

**From the build log** The correct files (including some_file.py) are listed under "Files changed"
The file with the violation (file.py) is listed in "Files with violations" which make sense
But that file (file.py) is also listed in "Will include violations on" although it's not in the PR
None of these files are listed in "Will not include violations on unchanged files"

**Configuration** I have the following selected:
- Keep old comments
- Create one comment per violation
- Comment only changed files

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.