jenkinsci / jenkinsci/syslog-java-client

Multiple things could slowdown drastically TcpSyslogMessageSender

Open
#41 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
91
Forks
71
PR merge metrics
No merged PRs in 30d

Description

TcpSyslogMessageSender has three things that need to be change in order for that class to be more reliable regarding performance

1. Connection timeout should be configurable and have a default value of 5ms (or even less)
2. Inner retry mechanism should be remove or be configurable
3. sendMessage should not be a synchronize method (actually one thread at a time can sent a log and could lead to huge slowdown when there is high volume of event being log)
- my recommendation is to start using non-blocking socket and remove the synchronization in order to avoid any performance issue

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.