jenkinsci / jenkinsci/subversion-plugin
[JENKINS-13762] Subversion authentication module doesn't handle invalid cert file or wrong cert password for https-client-certificates correctly
- Dominant language
- Java
- Stars
- 131
- Forks
- 275
- Avg merge
- 12h 4m
- Merged PRs (30d)
- 6
Description
The subversion authentication module accepts any file as certificate and anything as password. A failure always results in the same not helpful exception "SSL handshake failed: 'Received fatal alert: handshake_failure'" after the subversion client send a empty client certificate send to the server on the TLS connection. I am not sure if is allowed to send a empty client certificate message to the server.
Due the complexity of the software chain and configuration parameters used for HTTPS authentication, it is very annoying to find the real problem if no component returns a usable error message.
The expected behavior is to validate the input parameters and do not try to establish a connection with obvious invalid parameters.
---
Originally reported by mborm, imported from: Subversion authentication module doesn't handle invalid cert file or wrong cert password for https-client-certificates correctly
Raw content of original issue
The subversion authentication module accepts any file as certificate and anything as password. A failure always results in the same not helpful exception "SSL handshake failed: 'Received fatal alert: handshake_failure'" after the subversion client send a empty client certificate send to the server on the TLS connection. I am not sure if is allowed to send a empty client certificate message to the server.
Due the complexity of the software chain and configuration parameters used for HTTPS authentication, it is very annoying to find the real problem if no component returns a usable error message.
The expected behavior is to validate the input parameters and do not try to establish a connection with obvious invalid parameters.
- environment:
Windows Server 2003, Java 1.6.0.31, Jenkins 1.463, Subversion Plugin 1.39
2 attachments
- [emptycertificate.png](https://issues.jenkins.io/secure/attachment/21818/emptycertificate.png)
> 
- [subversionException.txt](https://issues.jenkins.io/secure/attachment/21817/subversionException.txt)
Contributor guide
Assessment
This issue has not been assessed yet.