jenkinsci / jenkinsci/subversion-plugin

[JENKINS-42740] Consider newline characters in commit messages also for summary of build changes section

Open
#1,411 2 comments 0 reactions 0 assignees View on GitHub
component:subversion-plugin imported-jira-issue priority:minor resolution:unresolved
Dominant language
Java
Stars
131
Forks
275
Avg merge
12h 4m
Merged PRs (30d)
6

Description

Related (or a follow-up) to JENKINS-36521">JENKINS-36521.

I like the fix/improvement of the aforementioned issue, but there also seems to be a "Summary" section in old/classic UI's "Changes" section, that I think should also be adapted like this (if possible):



  • see

  • see "src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly", line 33

 

ljader added the following comment:


I've ran an initial analysis and I think parsing commit message should be implemented as in Git Plugin.

The git-plugin checks if there is a blank 2nd line (commit message with format http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) and displays only this line on main job page and each build page,

but it displays full commit message on "Changes" section (job/test-git-repo/4/changes).

Just for reference, please checkout usage of "msgAnnotated" and "commentAnnotated" here:

https://github.com/jenkinsci/git-plugin/blob/master/src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly

---
Originally reported by reinholdfuereder, imported from: Consider newline characters in commit messages also for summary of build changes section


  • status: Open
  • priority: Minor
  • component(s): subversion-plugin
  • resolution: Unresolved
  • votes: 0
  • watchers: 2
  • imported: 20251212-090250

Raw content of original issue

Related (or a follow-up) to JENKINS-36521.

I like the fix/improvement of the aforementioned issue, but there also seems to be a "Summary" section in old/classic UI's "Changes" section, that I think should also be adapted like this (if possible):



  • see

  • see "src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly", line 33

 

ljader added the following comment:


I've ran an initial analysis and I think parsing commit message should be implemented as in Git Plugin.
The git-plugin checks if there is a blank 2nd line (commit message with format http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) and displays only this line on main job page and each build page,
but it displays full commit message on "Changes" section (job/test-git-repo/4/changes).

Just for reference, please checkout usage of "msgAnnotated" and "commentAnnotated" here:
https://github.com/jenkinsci/git-plugin/blob/master/src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly

1 attachment

- [image-2017-03-14-08-13-38-771.png](https://issues.jenkins.io/secure/attachment/36506/image-2017-03-14-08-13-38-771.png)
> ![image-2017-03-14-08-13-38-771.png](https://issues.jenkins.io/secure/attachment/36506/image-2017-03-14-08-13-38-771.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.