jenkinsci / jenkinsci/subversion-plugin
[JENKINS-31310] Databound constructor clean-up
- Dominant language
- Java
- Stars
- 131
- Forks
- 275
- Avg merge
- 12h 4m
- Merged PRs (30d)
- 6
Description
The workflow snippet generator is suggesting this when requested for a SVN step (under General SCM Step, since the simplified version does not accept credentials):
checkout([$class: 'SubversionSCM', additionalCredentials: [], excludedCommitMessages: '', excludedRegions: '', excludedRevprop: '', excludedUsers: '', filterChangelog: false, ignoreDirPropChanges: false, includedRegions: '', locations: [[credentialsId: 'a30e416f-0240-4af6-bc4d-76a9f7a9de0e', depthOption: 'infinity', ignoreExternalsOption: true, local: '.', remote: 'http://svn.server/project/trunk']], workspaceUpdater: [$class: 'UpdateUpdater']])
Only two fields where really configured: remote and credentialsId, so any other configuration is not really required. An appropriated @DataBoundConstructor in SubversionSCM using only required fields (and @DataBoundSetter 's) would substantially improve the generated groovy code.
---
Originally reported by
amuniz, imported from: Databound constructor clean-up
recena
Raw content of original issue
The workflow snippet generator is suggesting this when requested for a SVN step (under General SCM Step, since the simplified version does not accept credentials):
checkout([$class: 'SubversionSCM', additionalCredentials: [], excludedCommitMessages: '', excludedRegions: '', excludedRevprop: '', excludedUsers: '', filterChangelog: false, ignoreDirPropChanges: false, includedRegions: '', locations: [[credentialsId: 'a30e416f-0240-4af6-bc4d-76a9f7a9de0e', depthOption: 'infinity', ignoreExternalsOption: true, local: '.', remote: 'http://svn.server/project/trunk']], workspaceUpdater: [$class: 'UpdateUpdater']])Only two fields where really configured: remote and credentialsId, so any other configuration is not really required. An appropriated @DataBoundConstructor in SubversionSCM using only required fields (and @DataBoundSetter 's) would substantially improve the generated groovy code.
environment
```
Jenkins 1.609.1
Workflow 1.10.1
Subversion Plugin 2.5.3
```
Contributor guide
Assessment
This issue has not been assessed yet.