jenkinsci / jenkinsci/subversion-plugin
[JENKINS-21907] Class hudson.scm.SVNRevisionState should be public
- Dominant language
- Java
- Stars
- 131
- Forks
- 275
- Avg merge
- 12h 4m
- Merged PRs (30d)
- 6
Description
I'm developing a Jenkins plugin that scans existing builds for the Subversion revisions being used. This information is stored in SVNRevisionState actions (https://github.com/jenkinsci/subversion-plugin/blob/master/src/main/java/hudson/scm/SVNRevisionState.java).
Unfortunately, SVNRevisionState is not public, but has default (=package private) visibility only, so other plugins can't use this class. I would suggest raising visibility for this class and its member to public.
This has been done successfully a long time ago in the Hudson fork ;O) of the Subversion plugin (https://github.com/eclipse/hudson.plugins.subversion/blob/master/src/main/java/hudson/scm/SVNRevisionState.java) and also in the corresponding action of the Git plugin (https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/util/BuildData.java).
Pull request with suggested code change is at https://github.com/jenkinsci/subversion-plugin/pull/68.
---
Originally reported by
swiest, imported from: Class hudson.scm.SVNRevisionState should be public
Raw content of original issue
I'm developing a Jenkins plugin that scans existing builds for the Subversion revisions being used. This information is stored in SVNRevisionState actions (https://github.com/jenkinsci/subversion-plugin/blob/master/src/main/java/hudson/scm/SVNRevisionState.java).
Unfortunately, SVNRevisionState is not public, but has default (=package private) visibility only, so other plugins can't use this class. I would suggest raising visibility for this class and its member to public.
This has been done successfully a long time ago in the Hudson fork ;O) of the Subversion plugin (https://github.com/eclipse/hudson.plugins.subversion/blob/master/src/main/java/hudson/scm/SVNRevisionState.java) and also in the corresponding action of the Git plugin (https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/util/BuildData.java).
Pull request with suggested code change is at https://github.com/jenkinsci/subversion-plugin/pull/68.
Contributor guide
Assessment
This issue has not been assessed yet.