jenkinsci / jenkinsci/script-security-plugin
[JENKINS-49701] Would like a new section of the Script security approval page to be "pending scripts from Disabled Jobs"
- Dominant language
- Java
- Stars
- 76
- Forks
- 181
- Avg merge
- 14h 55m
- Merged PRs (30d)
- 3
Description
Request:
Create a new section inside of the "In Process Script Approval" screen which shows pending approvals which are coming from disabled jobs
Reasoning:
There are some situations where you want to deny some scripts where developers are potentially doing bad things. But when Jenkins is restarted, those denied scripts come back to the "In Process Script Approval" screen which is annoying. It would be great to have a way to isolate those scripts which are not being fixed by developers. This could be accomplished by disabling their projects and then being able to sort their scripts so that new scripts waiting on approval are not lumped in with the bad ones on restart.
Implementation:
`ScriptApproval/index.jelly` could perhaps show a special UI for `PendingThing`s whose `context` has an `item` which is in fact a `disabled` `Job`. So this would mean creating a new UI box and putting scripts into it with the disabled job flag.
Thoughts?
---
Originally reported by 
ataylor, imported from: Would like a new section of the Script security approval page to be "pending scripts from Disabled Jobs"
Raw content of original issue
Request:
Create a new section inside of the "In Process Script Approval" screen which shows pending approvals which are coming from disabled jobs
Reasoning:
There are some situations where you want to deny some scripts where developers are potentially doing bad things. But when Jenkins is restarted, those denied scripts come back to the "In Process Script Approval" screen which is annoying. It would be great to have a way to isolate those scripts which are not being fixed by developers. This could be accomplished by disabling their projects and then being able to sort their scripts so that new scripts waiting on approval are not lumped in with the bad ones on restart.
Implementation:
`ScriptApproval/index.jelly` could perhaps show a special UI for `PendingThing`s whose `context` has an `item` which is in fact a `disabled` `Job`. So this would mean creating a new UI box and putting scripts into it with the disabled job flag.
Thoughts?
Contributor guide
Assessment
This issue has not been assessed yet.