jenkinsci / jenkinsci/plugin-pom
Remove `provided` dependency on `commons-logging`
- Dominant language
- Java
- Stars
- 75
- Forks
- 81
- Avg merge
- 9m
- Merged PRs (30d)
- 18
Description
The `provided` dependency on `commons-logging` is inconsistent with the general design of this POM, which avoids specifying Jenkins core dependencies in order to allow them to be fetched from the Jenkins core BOM.
For a comprehensive fix, the `provided` dependency should be removed both from here and from Jenkins core. The main implementation/testing challenge here is to avoid a regression with regard to https://www.slf4j.org/codes.html#release
The relevant test scenarios are:
1. Jenkins core before the change to remove `commons-logging`, plugin POM before the change to remove `commons-logging` (the status quo)
2. Jenkins core before the change to remove `commons-logging`, plugin POM after the change to remove `commons-logging` (the scenario when a plugin updates its parent POM but not its core)
3. Jenkins core after the change to remove `commons-logging`, plugin POM before the change to remove `commons-logging` (the scenario when a plugin updates its core but not its parent POM)
4. Jenkins core after the change to remove `commons-logging`, plugin POM after the change to remove `commons-logging` (the scenario when a plugin updates both its core and its parent POM)
A test scenario should be set up to expose https://www.slf4j.org/codes.html#release in both core and a plugin, and the results of (1) in both scenarios should be measured to establish a baseline. Then (2), (3), and (4) should also be measured in all applicable scenarios to assure there are no regressions.
Contributor guide
Assessment
This issue has not been assessed yet.