jenkinsci / jenkinsci/plugin-pom

[JENKINS-48058] plugin pom overloads maven properties for evil things

Open
#1,300 8 comments 0 reactions 0 assignees View on GitHub
component:plugin-pom imported-jira-issue priority:major resolution:unresolved
Dominant language
Java
Stars
75
Forks
81
Avg merge
9m
Merged PRs (30d)
18

Description

The plugin pom has profiles and other things that are setup by virtue of a plugin specific flag being set.

For example javadoc publishig is skiped with "skipTests" property.

Similar for findbugs.

This is very bad as you may want to speed a release by skipping tests (using the standard maven way[1]) in the perform goal yet this leads to the surprising thing that javadocs are missing. This is very costly and it is NOT the maven way. The POM has even invented its own workaround for this that again is not what maven users would expect

If you want to bind things to "tests not being run" then they should be bound to general maven properties like maven.test.skip and NOT a plugin specific property.

If we want to be helpful to people so that they do not have to type long flags then we set a profile with an id of "quickBuild" that configures specific plugin flags

[1] -Darguments=-DskipTests

---
Originally reported by teilo, imported from: plugin pom overloads maven properties for evil things


  • status: Open
  • priority: Major
  • component(s): plugin-pom
  • resolution: Unresolved
  • votes: 0
  • watchers: 3
  • imported: 20260108-221235

Raw content of original issue

The plugin pom has profiles and other things that are setup by virtue of a plugin specific flag being set.

For example javadoc publishig is skiped with "skipTests" property.
Similar for findbugs.

This is very bad as you may want to speed a release by skipping tests (using the standard maven way[1]) in the perform goal yet this leads to the surprising thing that javadocs are missing. This is very costly and it is NOT the maven way. The POM has even invented its own workaround for this that again is not what maven users would expect

If you want to bind things to "tests not being run" then they should be bound to general maven properties like maven.test.skip and NOT a plugin specific property.

If we want to be helpful to people so that they do not have to type long flags then we set a profile with an id of "quickBuild" that configures specific plugin flags

[1] -Darguments=-DskipTests

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.