jenkinsci / jenkinsci/plugin-installation-manager-tool

CLI tool does not return an error code when it says "War not found"

Open
#641 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
463
Forks
228
Avg merge
31m
Merged PRs (30d)
15

Description

### Jenkins and plugins versions report

Environment


```text
Paste the output here
```

### What Operating System are you using (both controller, and any agents involved in the problem)?

Using https://hub.docker.com/r/jenkins/jenkins running on Amazon Linux 2
Being built within a jenkins job

### Reproduction steps

Run jenkins-plugin-cli with a plugin file on a system with a non default jenkins.war
It gives an error
No exit code

### Expected Results

any error code

### Actual Results

No exit code

### Anything else?

This is related to this raised issue: https://github.com/jenkinsci/docker/issues/1803

The problem here is we are creating our own docker file from the image listed above, in the docker build we are installing the plugins and then deploying that.

This step does not stop the docker build since it does not error, so it continues with the build, in our case will deploy. This put us in a broken state. Since it tried to deploy an unknown plugin state and possibly upgrade some files, when it automatically downgraded Jenkins to the last working container it was not able to properly start up either.

Since there was no error, it also made tracking down exactly what happened that much harder.

### Are you interested in contributing a fix?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.