jenkinsci / jenkinsci/parameterized-trigger-plugin
[JENKINS-47442] Parameterized Trigger hangs waiting for downstream job
- Dominant language
- Java
- Stars
- 77
- Forks
- 174
- Avg merge
- 22h 27m
- Merged PRs (30d)
- 1
Description
We use Parameterized Trigger to launch downstream jobs from a Promoted Builds promotion. The problem is that if the downstream job queues then the Promotion job hangs waiting for it. The stack trace is:
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Object.java:502)
hudson.remoting.AsyncFutureImpl.get(AsyncFutureImpl.java:73)
hudson.plugins.parameterizedtrigger.BuildTrigger.perform(BuildTrigger.java:111)
hudson.plugins.promoted_builds.Promotion$RunnerImpl.build(Promotion.java:425)
hudson.plugins.promoted_builds.Promotion$RunnerImpl.doRun(Promotion.java:367)
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:496)
hudson.model.Run.execute(Run.java:1737)
hudson.model.Run.run(Run.java:1694)
hudson.plugins.promoted_builds.Promotion.run(Promotion.java:290)
hudson.model.ResourceController.execute(ResourceController.java:97)
hudson.model.Executor.run(Executor.java:421)
I think it relates to this line in BuildTrigger.java.
abstractBuild = (AbstractBuild) future.get();
It was added in https://github.com/jenkinsci/parameterized-trigger-plugin/commit/a6de43746b11ae2113405f56203066af42abb124#diff-124e73168bc42ab0df38c0656f9aec8b
We have downgraded the Parameterized Trigger plugin to 2.32 (prior to the above commit) resolves the issue, but there are security warnings for the older version so we'd like to be able to upgrade again.
To replicate, use Promoted Builds to trigger a long running downstream job. After the first or second promotion you should see the promotion job hang waiting on the downstream job.
---
Originally reported by mark_h, imported from: Parameterized Trigger hangs waiting for downstream job
Raw content of original issue
We use Parameterized Trigger to launch downstream jobs from a Promoted Builds promotion. The problem is that if the downstream job queues then the Promotion job hangs waiting for it. The stack trace is:
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Object.java:502)
hudson.remoting.AsyncFutureImpl.get(AsyncFutureImpl.java:73)
hudson.plugins.parameterizedtrigger.BuildTrigger.perform(BuildTrigger.java:111)
hudson.plugins.promoted_builds.Promotion$RunnerImpl.build(Promotion.java:425)
hudson.plugins.promoted_builds.Promotion$RunnerImpl.doRun(Promotion.java:367)
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:496)
hudson.model.Run.execute(Run.java:1737)
hudson.model.Run.run(Run.java:1694)
hudson.plugins.promoted_builds.Promotion.run(Promotion.java:290)
hudson.model.ResourceController.execute(ResourceController.java:97)
hudson.model.Executor.run(Executor.java:421)I think it relates to this line in BuildTrigger.java.
abstractBuild = (AbstractBuild) future.get();It was added in https://github.com/jenkinsci/parameterized-trigger-plugin/commit/a6de43746b11ae2113405f56203066af42abb124#diff-124e73168bc42ab0df38c0656f9aec8b
We have downgraded the Parameterized Trigger plugin to 2.32 (prior to the above commit) resolves the issue, but there are security warnings for the older version so we'd like to be able to upgrade again.
To replicate, use Promoted Builds to trigger a long running downstream job. After the first or second promotion you should see the promotion job hang waiting on the downstream job.
- environment:
Jenkins 2.73.2, Parameterized Trigger Plugin 2.35.1, Promoted Builds 2.29.1
Contributor guide
Assessment
This issue has not been assessed yet.