jenkinsci / jenkinsci/parameterized-trigger-plugin

[JENKINS-34009] plugin doesn't perform conversion for subtypes of StringParameterDefinition

Open
#667 1 comment 0 reactions 0 assignees View on GitHub
component:parameterized-trigger-plugin imported-jira-issue priority:minor resolution:unresolved
Dominant language
Java
Stars
77
Forks
174
Avg merge
22h 27m
Merged PRs (30d)
1

Description

Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/94

ParameterDefinition types which extend StringParameterDefinition still need to be converted, when possible, in order to ensure correct handling of any additional logic implemented by the sub-type.

The code change is simply to use a more exacting check then the instanceof keyword because any parameter types which sub-class StringParameterDefinition in order to avoid re-implemeting its behaviour are not currently converted when they could be.

---
Originally reported by jcarrothers_sap, imported from: plugin doesn't perform conversion for subtypes of StringParameterDefinition


  • assignee: huybrechts
  • status: Open
  • priority: Minor
  • component(s): parameterized-trigger-plugin
  • resolution: Unresolved
  • votes: 1
  • watchers: 2
  • imported: 2025-12-07

Raw content of original issue

Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/94

ParameterDefinition types which extend StringParameterDefinition still need to be converted, when possible, in order to ensure correct handling of any additional logic implemented by the sub-type.

The code change is simply to use a more exacting check then the instanceof keyword because any parameter types which sub-class StringParameterDefinition in order to avoid re-implemeting its behaviour are not currently converted when they could be.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.