jenkinsci / jenkinsci/parameterized-trigger-plugin
[JENKINS-34009] plugin doesn't perform conversion for subtypes of StringParameterDefinition
- Dominant language
- Java
- Stars
- 77
- Forks
- 174
- Avg merge
- 22h 27m
- Merged PRs (30d)
- 1
Description
Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/94
ParameterDefinition types which extend StringParameterDefinition still need to be converted, when possible, in order to ensure correct handling of any additional logic implemented by the sub-type.
The code change is simply to use a more exacting check then the instanceof keyword because any parameter types which sub-class StringParameterDefinition in order to avoid re-implemeting its behaviour are not currently converted when they could be.
---
Originally reported by jcarrothers_sap, imported from: plugin doesn't perform conversion for subtypes of StringParameterDefinition
Raw content of original issue
Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/94
ParameterDefinition types which extend StringParameterDefinition still need to be converted, when possible, in order to ensure correct handling of any additional logic implemented by the sub-type.
The code change is simply to use a more exacting check then the instanceof keyword because any parameter types which sub-class StringParameterDefinition in order to avoid re-implemeting its behaviour are not currently converted when they could be.
Contributor guide
Assessment
This issue has not been assessed yet.