jenkinsci / jenkinsci/material-theme-plugin

Improve contrast with 'ansi-xx-d' console colourisation.

Open
#59 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
17
Forks
14
PR merge metrics
No merged PRs in 30d

Description

### Jenkins and plugins versions report

Environment


```text
Paste the output here
```

### What Operating System are you using (both controller, and any agents involved in the problem)?

Any OS or browser.

### Reproduction steps

1. Install Pipeline Graph View Plugin.
2. Ensure ANSI Plugin global setting is disabled.
3. Write a Pipeline that outputs ANSI codes, e.g.
```
pipeline {
agent none
options {
ansiColor('xterm')
}
stages {
stage('Color') {
steps {
echo('\033[34mHello\033[0m \033[33mcolorful\033[0m \033[35mworld\033[0m')
}
}
}
}
```
4. Run Pipeline
5. View console text in Pipeline Console.

### Expected Results

Readable text, e.g.
![Screenshot 2022-11-08 at 14 17 30](https://user-images.githubusercontent.com/4447764/200584578-9f7f3a0e-fba0-44f2-971b-e6f3167d595b.png)

or:
![Screenshot 2022-11-08 at 14 17 40](https://user-images.githubusercontent.com/4447764/200588297-8eaee33f-9819-4a42-ad59-b430c9249fbd.png)

### Actual Results

Text is difficult to read:
![Screenshot 2022-11-08 at 14 17 50](https://user-images.githubusercontent.com/4447764/200584627-3a22f220-04c1-47cb-b4b0-7bb3a7dc6d43.png)

### Anything else?

We could look at using similar colours to the Dark Theme:
https://github.com/jenkinsci/dark-theme-plugin/blob/master/src/main/frontend/main.scss

The classes to override are defined in:
https://github.com/jenkinsci/pipeline-graph-view-plugin/blob/main/src/main/frontend/pipeline-console-view/pipeline-console/main/pipeline-console.scss#L92

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.