jenkinsci / jenkinsci/jfrog-plugin

Proxy password special chars encoding

Open
#53 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
16
Forks
85
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug

Hi,

I'm facing an issue with jfrog plugin due to special chars (e.g # char) used with the jenkins http proxy defined. The CliEnvConfigurator in setupProxy method just concatenates proxy info (scheme + username:password@host:port). So if the password has a special chars, the value set in env variables HTTPS_PROXY leader to ambigous errors( For instance : https://myusername: my#p@ssword@myproxyhost:myproxyport).

Regards

### Current behavior

My configuration is :
- A Jenkins instance + a slave with a corporation proxy defined
- a jfrog plugin installed manually and configure with the corporation jfrog service
- the jf mvn-config set
- a pipeline which execute jf 'mvn clean deploy'

### Reproduction steps

- Define a jenkins proxy configuration
- Install jfrog plugin, install and configure the jfrog cli
- Install and configure maven
- Create a scripted pipeline with a step executing jf 'mvn --version'

### Expected behavior

_No response_

### JFrog plugin version

1.5.5

### JFrog CLI version

2.61

### Operating system type and version

Réel 8

### JFrog Artifactory version

7.104

### JFrog Xray version

_No response_

Contributor guide

Open the contributing guide

Research direction

Start at CliEnvConfigurator.setupProxy, where the proxy information is concatenated into the HTTPS_PROXY environment value. Trace the JFrog CLI Maven pipeline described in the reproduction steps and verify that credentials containing characters such as # are represented unambiguously; done means that pipeline can use the configured proxy successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.