jenkinsci / jenkinsci/gitlab-plugin

GitlabPushTrigger: config triggerOnPush = false and triggerOnAcceptedMergeRequest = true is ignored in Pipeline Jenkins job

Open
#1,427 2 comments 4 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
1.4k
Forks
615
Avg merge
4h 32m
Merged PRs (30d)
10

Description

### Jenkins and plugins versions report

Environment


```text
Jenkins: 2.387.1
GitLab: v15.9.3-ee
gitlab-plugin: 1.7.8
OS: Linux
Java: 17.0.2 OpenJDK 64-Bit Server VM
```

### What Operating System are you using (both controller, and any agents involved in the problem)?

- Ubuntu 20.04
- Windows agent, version 3071.v7e9b_0dc08466 (Windows 10 Business)

### Reproduction steps

1. Setup Gitlab plugin like [this](https://about.gitlab.com/handbook/customer-success/demo-systems/tutorials/integrations/create-jenkins-pipeline/)
2. Create a Pipeline Jenkins job
3. Use the following config in the pipeline:
```
properties([
gitlabConnection(gitlabConnection: 'connectionName', userAlternativeCredential: true, jobCredentialId: 'credsName'),
pipelineTriggers([
gitlab(triggerOnPush: false, triggerOnMergeRequest: false, triggerOnAcceptedMergeRequest: true, branchFilterType: 'All')
])
])
```
4. **pls pay attention at the following:** triggerOnPush: **false**, triggerOnMergeRequest: **false**, triggerOnAcceptedMergeRequest: **true**
5. Pipeline Jenkins job is triggered on every push event into gitlab repo Merge Request branch

### Expected Results

On gitlab-plugin: 1.6.0 the following config
`gitlab(triggerOnPush: false, triggerOnMergeRequest: false, triggerOnAcceptedMergeRequest: true, branchFilterType: 'All')`

triggered Pipeline Jenkins job on merged Merge Request event only.

### Actual Results

After updating gitlab-plugin from 1.6.0 to 1.7.8 the same config
`gitlab(triggerOnPush: false, triggerOnMergeRequest: false, triggerOnAcceptedMergeRequest: true, branchFilterType: 'All')`

triggers Pipeline Jenkins job on every push event on Merge Request branch

### Anything else?

**Pleas note:** that this issue is not reproducible for Freestyle Jenkins job.

If anything else is needed, please let me know.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.