jenkinsci / jenkinsci/github-pr-coverage-status-plugin

Feature: make configurable status check on coverage drop or add a kind of "tollerance"

Open
#84 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
97
Forks
101
PR merge metrics
No merged PRs in 30d

Description

Hi,

First, thanks a lot for your work in this plugin, it's very useful for my organization even if code coverage reporting is a ~stressful~ topic.

I noticed that from version [2.1.1](https://github.com/jenkinsci/github-pr-coverage-status-plugin/releases/tag/github-pr-coverage-status-2.1.1), is present the possibility to

> Fail the status check when the coverage decreased

which is great and a fair point of discussion for the proposed code in PR but sometimes the report show something like that:

![9695c93b-4837-4f9c-9e21-f88660ff1e75](https://user-images.githubusercontent.com/8403734/80528063-9cadf500-8995-11ea-8698-e5ba53f327b1.jpg)

which generate a bit of confusion and some awful discussion. I think that the reported value is truncated but the status check is evaluated with the complete value. Maybe a solution could be:

- evaluate the status with the same value reported in the PR
- add the possibility to disable the commit status or configure a tollerance value in which the status check is successful or failed.

Again thanks a lot for your work!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.