[JENKINS-73787] Revisit snapshotting of GitHubAppCredentials

The current design of the GitHubAppCredentials snapshotting is messy as discussed in https://github.com/jenkinsci/github-branch-source-plugin/pull/810#discussion_r1761493599.

GitHubAppCredentials#writeReplace directly return a DelegatingGitHubAppCredentials which should not be necessary, or rather should rely on the CredentialsSnapshotTaker entirely.

---
Originally reported by allan_burdajewicz, imported from: Revisit snapshotting of GitHubAppCredentials

• status: Open
  
• priority: Major
  
• component(s): github-branch-source-plugin
  
• resolution: Unresolved
  
• votes: 0
  
• watchers: 2
  
• imported: 2025-12-02
  

The current design of the GitHubAppCredentials snapshotting is messy as discussed in https://github.com/jenkinsci/github-branch-source-plugin/pull/810#discussion_r1761493599.


GitHubAppCredentials#writeReplace directly return a DelegatingGitHubAppCredentials which should not be necessary, or rather should rely on the CredentialsSnapshotTaker entirely.