jenkinsci / jenkinsci/github-branch-source-plugin
[JENKINS-71849] Request to not make an API limit decision for the user
- Dominant language
- Java
- Stars
- 217
- Forks
- 398
- Avg merge
- 30m
- Merged PRs (30d)
- 1
Description
This impacts our ability to get proper GitHub support. Our company has enterprise support and one of the conditions for us to get higher GitHub App limits is that we actually use up to the limit and show errors of us hitting the limit. GitHub enterprise support worked with us to raise our app limits once but will not raise them again due to our usage profile.
Because this setting is ignored for github.com (of which we're using hosted GitHub Enterprise). Jenkins throttles API limits despite us configuring limits to be ignored.
- This produces a terrible developer experience because our users see delays.
- It has a bad admin experience because we're challenged by GitHub support to hit our limits when this simply isn't possible with the current implementation of the GitHub branch source plugin.
We tried disabling limit monitoring but the logs state:
```
2023-08-17 17:20:00.949+0000 [id=3390317] INFO o.j.p.g.ApiRateLimitChecker$RateLimitCheckerAdapter#checkRateLimit: GitHub throttling is disabled, which is not allowed for public GitHub usage, so ThrottleOnOver will be used instead. To configure a different rate limiting strategy, go to "GitHub API usage" under "Configure System" in the Jenkins settings.
```
---
Originally reported by
sag47, imported from: Request to not make an API limit decision for the user
Raw content of original issue
This impacts our ability to get proper GitHub support. Our company has enterprise support and one of the conditions for us to get higher GitHub App limits is that we actually use up to the limit and show errors of us hitting the limit. GitHub enterprise support worked with us to raise our app limits once but will not raise them again due to our usage profile.
Because this setting is ignored for github.com (of which we're using hosted GitHub Enterprise). Jenkins throttles API limits despite us configuring limits to be ignored.
- This produces a terrible developer experience because our users see delays.
- It has a bad admin experience because we're challenged by GitHub support to hit our limits when this simply isn't possible with the current implementation of the GitHub branch source plugin.
We tried disabling limit monitoring but the logs state:
2023-08-17 17:20:00.949+0000 [id=3390317] INFO o.j.p.g.ApiRateLimitChecker$RateLimitCheckerAdapter#checkRateLimit: GitHub throttling is disabled, which is not allowed for public GitHub usage, so ThrottleOnOver will be used instead. To configure a different rate limiting strategy, go to "GitHub API usage" under "Configure System" in the Jenkins settings.
Contributor guide
Assessment
This issue has not been assessed yet.