jenkinsci / jenkinsci/github-branch-source-plugin

[JENKINS-70519] Add appropriate warning about files driving the build in trusted PR sources help

Open
#1,417 0 comments 0 reactions 0 assignees View on GitHub
component:github-branch-source-plugin enhancement imported-jira-issue priority:minor resolution:unresolved
Dominant language
Java
Stars
217
Forks
398
Avg merge
30m
Merged PRs (30d)
1

Description

The help of "Trust" in "Discover pull requests from forks", talks about trusted files, but does not give a hint where they can be configured if it is possible.

Also a warning about the importance of understanding the security implications of letting others run a build. Which files drive the build process? What are the opportunities for a malicious PR author to leak credentials or access trusted resources? An often overlooked part is the tests, which may require some credentials to integrate with other systems, and by the nature of it, can anything programmed in the tests with those credentials.

Also, without appropriate isolation measures everything accessible for the jenkins OS user is accessible for the tests.

I guess I have left important points out, some of the above are mitigated by other jenkins plugins, and I am sure there are good articles about these security considerations.

My main message is that if there is no appropriate warning here, then the user might have a false sense of security by using this setting alone.

---
Originally reported by magwas, imported from: Add appropriate warning about files driving the build in trusted PR sources help


  • status: Open
  • priority: Minor
  • component(s): github-branch-source-plugin
  • resolution: Unresolved
  • votes: 0
  • watchers: 1
  • imported: 2025-12-02

Raw content of original issue

The help of "Trust" in "Discover pull requests from forks", talks about trusted files, but does not give a hint where they can be configured if it is possible.
Also a warning about the importance of understanding the security implications of letting others run a build. Which files drive the build process? What are the opportunities for a malicious PR author to leak credentials or access trusted resources? An often overlooked part is the tests, which may require some credentials to integrate with other systems, and by the nature of it, can anything programmed in the tests with those credentials.
Also, without appropriate isolation measures everything accessible for the jenkins OS user is accessible for the tests.

I guess I have left important points out, some of the above are mitigated by other jenkins plugins, and I am sure there are good articles about these security considerations.

My main message is that if there is no appropriate warning here, then the user might have a false sense of security by using this setting alone.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.