jenkinsci / jenkinsci/github-branch-source-plugin
[JENKINS-65978] Editing a GitHub PR description should not trigger a new build for the same commit
- Dominant language
- Java
- Stars
- 217
- Forks
- 398
- Avg merge
- 30m
- Merged PRs (30d)
- 1
Description
Somehow I started to see PRs get built over and over (for the same commit) when their PR description get changed.
I don't recall to see that behaviour in the past. It's not something only in our end but also in the ci.jenkins.io
To illustrate the above see the below example:
- I created https://github.com/jenkinsci/opentelemetry-plugin/pull/135 with only one commit.
- Therefore
- Then I edited the description
- Then a new build got triggered https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fopentelemetry-plugin/detail/PR-135/3/pipeline
- Even though the build 2 was a branch index for the same commit and build 1 was a push event for the same commit.
In the https://ci.jenkins.io/job/Plugins/job/opentelemetry-plugin/indexing/events I can see the below logs
[Thu Jun 24 08:13:39 UTC 2021] Received Pull request #135 event in repository jenkinsci/opentelemetry-plugin UPDATED event from 140.82.115.251 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Thu Jun 24 08:13:34 UTC 2021 08:13:39 Connecting to https://api.github.com using ci.jenkins.io GitHub App (jenkinsci org) Examining jenkinsci/opentelemetry-plugin Checking pull-requests... Getting remote pull request #135... [Thu Jun 24 08:13:39 UTC 2021] Received Pull request #135 event in repository jenkinsci/opentelemetry-plugin UPDATED event from 140.82.115.152 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Thu Jun 24 08:13:34 UTC 2021 08:13:39 Connecting to https://api.github.com using ci.jenkins.io GitHub App (jenkinsci org) Examining jenkinsci/opentelemetry-plugin Checking pull-requests... Getting remote pull request #135...
[Thu Jun 24 08:13:39 UTC 2021] Received Pull request #135 event in repository jenkinsci/opentelemetry-plugin UPDATED event from 140.82.115.246 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Thu Jun 24 08:13:34 UTC 2021 08:13:39 Connecting to https://api.github.com using ci.jenkins.io GitHub App (jenkinsci org) Examining jenkinsci/opentelemetry-plugin Checking pull-requests... Getting remote pull request #135... Checking pull request #135 ‘Jenkinsfile’ found Checking pull request #135
And also a screenshot
---
Originally reported by 
v2v, imported from: Editing a GitHub PR description should not trigger a new build for the same commit
Raw content of original issue
Somehow I started to see PRs get built over and over (for the same commit) when their PR description get changed.
I don't recall to see that behaviour in the past. It's not something only in our end but also in the ci.jenkins.io
To illustrate the above see the below example:
- I created https://github.com/jenkinsci/opentelemetry-plugin/pull/135 with only one commit.
- Therefore
- Then I edited the description
- Then a new build got triggered https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fopentelemetry-plugin/detail/PR-135/3/pipeline
- Even though the build 2 was a branch index for the same commit and build 1 was a push event for the same commit.
In the https://ci.jenkins.io/job/Plugins/job/opentelemetry-plugin/indexing/events I can see the below logs
[Thu Jun 24 08:13:39 UTC 2021] Received Pull request #135 event in repository jenkinsci/opentelemetry-plugin UPDATED event from 140.82.115.251 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Thu Jun 24 08:13:34 UTC 2021 08:13:39 Connecting to https://api.github.com using ci.jenkins.io GitHub App (jenkinsci org) Examining jenkinsci/opentelemetry-plugin Checking pull-requests... Getting remote pull request #135... [Thu Jun 24 08:13:39 UTC 2021] Received Pull request #135 event in repository jenkinsci/opentelemetry-plugin UPDATED event from 140.82.115.152 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Thu Jun 24 08:13:34 UTC 2021 08:13:39 Connecting to https://api.github.com using ci.jenkins.io GitHub App (jenkinsci org) Examining jenkinsci/opentelemetry-plugin Checking pull-requests... Getting remote pull request #135...
[Thu Jun 24 08:13:39 UTC 2021] Received Pull request #135 event in repository jenkinsci/opentelemetry-plugin UPDATED event from 140.82.115.246 ⇒ https://ci.jenkins.io/github-webhook/ with timestamp Thu Jun 24 08:13:34 UTC 2021 08:13:39 Connecting to https://api.github.com using ci.jenkins.io GitHub App (jenkinsci org) Examining jenkinsci/opentelemetry-plugin Checking pull-requests... Getting remote pull request #135... Checking pull request #135 ‘Jenkinsfile’ found Checking pull request #135
And also a screenshot
environment
```
Core: 2.289.1
Plugins: 2.11.1
```
2 attachments
- [image-2021-06-24-09-38-11-232.png](https://issues.jenkins.io/secure/attachment/55058/image-2021-06-24-09-38-11-232.png)
> 
- [image-2021-06-24-09-42-06-636.png](https://issues.jenkins.io/secure/attachment/55057/image-2021-06-24-09-42-06-636.png)
> 
Contributor guide
Assessment
This issue has not been assessed yet.