jenkinsci / jenkinsci/github-branch-source-plugin

[JENKINS-64493] Off-by-one in retry event log message

Open
#1,331 0 comments 0 reactions 0 assignees View on GitHub
component:github-branch-source-plugin imported-jira-issue priority:trivial resolution:unresolved
Dominant language
Java
Stars
217
Forks
398
Avg merge
30m
Merged PRs (30d)
1

Description

There is a off-by-one condition in the message that appears in the multibranch event log:

 

    Checking pull request #2742

Waiting for GitHub to create a merge commit for pull request 2742. Retrying 4 more times...
Waiting for GitHub to create a merge commit for pull request 2742. Retrying 3 more times...
Waiting for GitHub to create a merge commit for pull request 2742. Retrying 2 more times...
‘Jenkinsfile’ not found
Does not meet criteria 

It always stops at "Retrying 2 more times..."

Either the condition is wrong or you should decrease the retry counter before printing this message. Code

 

 

---
Originally reported by dschey, imported from: Off-by-one in retry event log message


  • status: Open
  • priority: Trivial
  • component(s): github-branch-source-plugin
  • resolution: Unresolved
  • votes: 0
  • watchers: 2
  • imported: 2025-12-02

Raw content of original issue

There is a off-by-one condition in the message that appears in the multibranch event log:

 



    Checking pull request #2742

Waiting for GitHub to create a merge commit for pull request 2742. Retrying 4 more times...
Waiting for GitHub to create a merge commit for pull request 2742. Retrying 3 more times...
Waiting for GitHub to create a merge commit for pull request 2742. Retrying 2 more times...
‘Jenkinsfile’ not found
Does not meet criteria 


It always stops at "Retrying 2 more times..."

Either the condition is wrong or you should decrease the retry counter before printing this message. Code

 

 

environment

```
Jenkins 2.249.2

github-branch-source-plugin 2.8.2
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.