jenkinsci / jenkinsci/github-branch-source-plugin
[JENKINS-55726] GitHub commit status context not unique enough or configurable - jobs always overwrite each other
- Dominant language
- Java
- Stars
- 217
- Forks
- 398
- Avg merge
- 30m
- Merged PRs (30d)
- 1
Description
GitHub can incorrectly flag PRs as passing checks if multiple jobs run against the same repository.
Multiple jobs configured against the same source repo will incorrectly set all checks successful if the last completed check is successful.
In my opinion, if there is no mechanism to define mandatory and optional checks, then the worst status check should provide the overall result.
This could be a check prior to submitting status that validates the prior status is not unsuccessful, and it is the same git sha1, and it is a different job name.
The secondary issue here is that only a single link is added to the PR, and so there is no indication on the GitHub PR how many jobs ran.
---
Originally reported by
j3p0uk, imported from: GitHub commit status context not unique enough or configurable - jobs always overwrite each other
Raw content of original issue
GitHub can incorrectly flag PRs as passing checks if multiple jobs run against the same repository.
Multiple jobs configured against the same source repo will incorrectly set all checks successful if the last completed check is successful.
In my opinion, if there is no mechanism to define mandatory and optional checks, then the worst status check should provide the overall result.
This could be a check prior to submitting status that validates the prior status is not unsuccessful, and it is the same git sha1, and it is a different job name.
The secondary issue here is that only a single link is added to the PR, and so there is no indication on the GitHub PR how many jobs ran.
environment
```
CloudBees Jenkins Enterprise 2.107.34.0.1-fixed
GitHub API Plugin 1.90
GitHub Branch Source Plugin 2.3.5
```
Contributor guide
Assessment
This issue has not been assessed yet.