jenkinsci / jenkinsci/git-plugin
[JENKINS-36180] Jenkins triggers build on git SCM changes even if nothing matches Includes regions
- Dominant language
- Java
- Stars
- 694
- Forks
- 1.1k
- Avg merge
- 1h 29m
- Merged PRs (30d)
- 3
Description
Hi!
Our builds are set up to listen to changes on origin/master, and has "Included regions" configured. We are using Gitlab and makes heavy use of Merge Requests in Gitlab.
When we do a merge, where the branch has pulled changed form master, the git-plugin says the following:
Ignored commit 906b26b2029df2242edb4a591d8ba2e855594be8: No paths matched included region whitelist
Done. Took 4.5 sec
Changes found
No paths matched included whitelist, but it still triggers a build. I believe that this is because there are paths matching the included region whitelist, but they are in the commits that were in the merge from master->currentBranch.
The reproduction steps:
- Create 2 Jenkins jobs with different "Included regions whitelist"
- Job 1: src/a
- Job 2: src/b
- Create new branch (myBranch)
- Commit changes in `src/a`
- Switch to master branch
- Commit changes in `src/b`
- Push changes
- Switch to myBranch
- Pull changes from master (git pull origin master)
- Push changes
- Create a merge request from myBranch to master (via Gitlab)
- Accept merge request
This triggers both Job1 AND Job2, even if I've only committed to Job1's Included region whitelist in my branch. I believe that this is not desired behaviour.
---
Originally reported by thorseye, imported from: Jenkins triggers build on git SCM changes even if nothing matches Includes regions
Raw content of original issue
Hi!
Our builds are set up to listen to changes on origin/master, and has "Included regions" configured. We are using Gitlab and makes heavy use of Merge Requests in Gitlab.
When we do a merge, where the branch has pulled changed form master, the git-plugin says the following:
Ignored commit 906b26b2029df2242edb4a591d8ba2e855594be8: No paths matched included region whitelist
Done. Took 4.5 sec
Changes foundNo paths matched included whitelist, but it still triggers a build. I believe that this is because there are paths matching the included region whitelist, but they are in the commits that were in the merge from master->currentBranch.
The reproduction steps:
- Create 2 Jenkins jobs with different "Included regions whitelist"
- Job 1: src/a
- Job 2: src/b
- Create new branch (myBranch)
- Commit changes in `src/a`
- Switch to master branch
- Commit changes in `src/b`
- Push changes
- Switch to myBranch
- Pull changes from master (git pull origin master)
- Push changes
- Create a merge request from myBranch to master (via Gitlab)
- Accept merge request
This triggers both Job1 AND Job2, even if I've only committed to Job1's Included region whitelist in my branch. I believe that this is not desired behaviour.
Contributor guide
Assessment
This issue has not been assessed yet.