jenkinsci / jenkinsci/git-plugin
[JENKINS-26540] notifyCommit pushes with a sha1 trigger builds where scm polling is not enabled
- Dominant language
- Java
- Stars
- 694
- Forks
- 1.1k
- Avg merge
- 1h 29m
- Merged PRs (30d)
- 3
Description
Not sure if this is a bug or expected behaviour, but its a bit confusing.
If I call the notifyCommit URL without a sha1, then the build only triggers if 'scm polling' is enabled. However, if a sha1 is provided then the build triggers regardless.
I realise that when the sha1 is provided, strictly speaking this isn't 'polling' happening. However this means that the only way to disable triggering (eg for a nightly sonar build) is to enable the scm trigger, set no time and then select the "Ignore post-commit hooks" option. ie:
- polling disabled - triggers if and only if a sha1 was provided
- polling enabled - triggers
- polling enabled but skipped - doesn't trigger
this is a but unintuitive and confusing. The git plugin should require that polling is enabled (even with an empty time), just like it does if a sha1 isn't provided.
---
Originally reported by bbaetz, imported from: notifyCommit pushes with a sha1 trigger builds where scm polling is not enabled
Raw content of original issue
Not sure if this is a bug or expected behaviour, but its a bit confusing.
If I call the notifyCommit URL without a sha1, then the build only triggers if 'scm polling' is enabled. However, if a sha1 is provided then the build triggers regardless.
I realise that when the sha1 is provided, strictly speaking this isn't 'polling' happening. However this means that the only way to disable triggering (eg for a nightly sonar build) is to enable the scm trigger, set no time and then select the "Ignore post-commit hooks" option. ie:
- polling disabled - triggers if and only if a sha1 was provided
- polling enabled - triggers
- polling enabled but skipped - doesn't trigger
this is a but unintuitive and confusing. The git plugin should require that polling is enabled (even with an empty time), just like it does if a sha1 isn't provided.
Contributor guide
Assessment
This issue has not been assessed yet.