jenkinsci / jenkinsci/gerrit-trigger-plugin
[JENKINS-62258] second time change on WIP state does start build but doesn't give +1 Verify label anymore.
- Dominant language
- Java
- Stars
- 226
- Forks
- 289
- PR merge metrics
- No merged PRs in 30d
Description
Noticed that setting commit from WIP to review state and back to WIP. Then second time from turning commit from WIP to review state doesn't give +1 Verified label anymore.
User X Uploaded patch set 1. May 11 12:42
User X Patch Set 2: Patch Set 1 was rebased May 12 11:19
User X Uploaded patch set 3: Patch Set 2 was rebased. May 12 14:13
User X Uploaded patch set 4: Patch Set 3 was rebased. May 12 14:27
User X Patch Set 4: This change is ready for review. May 12 14:28
User X Set Ready For Review May 12 14:28
jenkins Patch Set 4: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/736/ May 12 14:42
jenkins Patch Set 4: Verified-1 Build Failed https://userx.server.com/jenkins/job/ci_test_x_web/736/ : Unit tests failed. May 12 14:46
User X Patch Set 5: Patch Set 4 was rebased May 12 15:13
User X Patch Set 6: Patch Set 5 was rebased May 12 15:24
jenkins Patch Set 5: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/741/ May 12 15:30
jenkins Patch Set 5: Verified+1 Build Successful https://userx.server.com/jenkins/job/ci_test_x_web/741/ : Unit tests successful. May 12 15:36
User X Patch Set 7: Patch Set 6 was rebased May 12 15:37
jenkins Patch Set 6: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/745/ May 12 15:53
jenkins Patch Set 6: Verified+1 Build Successful https://userx.server.com/jenkins/job/ci_test_x_web/745/ : Unit tests successful. May 12 15:59
jenkins Patch Set 7: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/749/ May 12 16:17
jenkins Patch Set 7: Verified-1 Build Failed https://userx.server.com/jenkins/job/ci_test_x_web/749/ : Unit tests failed. May 12 16:21
User X Set Work In Progress 08:21
User X Patch Set 7: This change is ready for review. 08:21
User X Set Ready For Review 08:21
jenkins Patch Set 7: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/750/ 08:21
jenkins Patch Set 7: Build Successful https://userx.server.com/jenkins/job/ci_test_x_web/750/ : Unit tests successful.' 08:26
It's a minor bug and but can be little bit annoying as it's easy to retrigger build by changing state of the WIP as a developer
---
Originally reported by kohtjuk, imported from: second time change on WIP state does start build but doesn't give +1 Verify label anymore.
rsandell
Raw content of original issue
Noticed that setting commit from WIP to review state and back to WIP. Then second time from turning commit from WIP to review state doesn't give +1 Verified label anymore.
User X Uploaded patch set 1. May 11 12:42
User X Patch Set 2: Patch Set 1 was rebased May 12 11:19
User X Uploaded patch set 3: Patch Set 2 was rebased. May 12 14:13
User X Uploaded patch set 4: Patch Set 3 was rebased. May 12 14:27
User X Patch Set 4: This change is ready for review. May 12 14:28
User X Set Ready For Review May 12 14:28
jenkins Patch Set 4: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/736/ May 12 14:42
jenkins Patch Set 4: Verified-1 Build Failed https://userx.server.com/jenkins/job/ci_test_x_web/736/ : Unit tests failed. May 12 14:46
User X Patch Set 5: Patch Set 4 was rebased May 12 15:13
User X Patch Set 6: Patch Set 5 was rebased May 12 15:24
jenkins Patch Set 5: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/741/ May 12 15:30
jenkins Patch Set 5: Verified+1 Build Successful https://userx.server.com/jenkins/job/ci_test_x_web/741/ : Unit tests successful. May 12 15:36
User X Patch Set 7: Patch Set 6 was rebased May 12 15:37
jenkins Patch Set 6: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/745/ May 12 15:53
jenkins Patch Set 6: Verified+1 Build Successful https://userx.server.com/jenkins/job/ci_test_x_web/745/ : Unit tests successful. May 12 15:59
jenkins Patch Set 7: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/749/ May 12 16:17
jenkins Patch Set 7: Verified-1 Build Failed https://userx.server.com/jenkins/job/ci_test_x_web/749/ : Unit tests failed. May 12 16:21
User X Set Work In Progress 08:21
User X Patch Set 7: This change is ready for review. 08:21
User X Set Ready For Review 08:21
jenkins Patch Set 7: Build Started https://userx.server.com/jenkins/job/ci_test_x_web/750/ 08:21
jenkins Patch Set 7: Build Successful https://userx.server.com/jenkins/job/ci_test_x_web/750/ : Unit tests successful.' 08:26It's a minor bug and but can be little bit annoying as it's easy to retrigger build by changing state of the WIP as a developer
environment
```
Jenkins: 2.222.3
OS: CentOS 7
Gerrit Trigger: 2.30.5
```
Contributor guide
Research direction
No source files or tests are identified in the issue. Start by locating the Gerrit event handling for WIP and ready-for-review transitions and the code that applies verification labels; reproduce the sequence described in the report, then add coverage showing that the second transition still applies the successful verification label.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100