jenkinsci / jenkinsci/gerrit-trigger-plugin
[JENKINS-28873] Rename email field in gerrit trigger configuration for better understanding
- Dominant language
- Java
- Stars
- 226
- Forks
- 289
- PR merge metrics
- No merged PRs in 30d
Description
Hi all
that took 3 days to recover this issue! When I filled in the fields of the gerrit trigger plugin configuration, I just put my email address into "E-mail" - I thought, this is just for some administrative stuff, when some severe error occurs.
Now, I entered a comment into a gerrit patch, but nothing happened. I did an ssh gerrit stream-event on the console, and all messages arrived as expected. Then, after looking for the 853rd time at the configuration, I saw the help text for this E-mail field: "The e-mail of the user in Gerrit. CommentAdded events from this user will be ignored by Jenkins."
I assume, this should prevent event-loops, but this is not clear from the field name. I'd rather propose something like
Ignore-Pattern
---
Originally reported by sonnenburg, imported from: Rename email field in gerrit trigger configuration for better understanding
rsandell
Raw content of original issue
Hi all
that took 3 days to recover this issue! When I filled in the fields of the gerrit trigger plugin configuration, I just put my email address into "E-mail" - I thought, this is just for some administrative stuff, when some severe error occurs.
Now, I entered a comment into a gerrit patch, but nothing happened. I did an ssh gerrit stream-event on the console, and all messages arrived as expected. Then, after looking for the 853rd time at the configuration, I saw the help text for this E-mail field: "The e-mail of the user in Gerrit. CommentAdded events from this user will be ignored by Jenkins."
I assume, this should prevent event-loops, but this is not clear from the field name. I'd rather propose something like
Ignore-Pattern
- environment:
Jenkins 1.617, Gerrit Trigger 2.14
Contributor guide
Research direction
Start in the gerrit trigger plugin configuration UI and find the field currently labeled "E-mail" with help text about ignoring CommentAdded events from a Gerrit user. Rename the field to make its event-loop prevention purpose clear, then verify that the configuration still identifies the user whose comments Jenkins ignores.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100