jenkinsci / jenkinsci/gerrit-trigger-plugin
[JENKINS-20808] Escaping of single quotes in commit message fails
- Dominant language
- Java
- Stars
- 226
- Forks
- 289
- PR merge metrics
- No merged PRs in 30d
Description
The gerrit-trigger plugin fails in escaping single quotes in the commit comment.
After I entered the following text as commit comment the mvn call that was triggered by the gerrit-trigger plugin fails with error "The system cannot find the file specified.":
Remove 'Custom' mode from "Connection Settings"
In the output of the jenkins job I could see that double quotes were escaped like: from \"Connection Settings\"
After I removed the single quotes from my comment the job run successful.
---
Originally reported by henrik_bennin, imported from: Escaping of single quotes in commit message fails
rsandell
Raw content of original issue
The gerrit-trigger plugin fails in escaping single quotes in the commit comment.
After I entered the following text as commit comment the mvn call that was triggered by the gerrit-trigger plugin fails with error "The system cannot find the file specified.":Remove 'Custom' mode from "Connection Settings"
In the output of the jenkins job I could see that double quotes were escaped like: from \"Connection Settings\"
After I removed the single quotes from my comment the job run successful.
environment
```
Gerrit-Trigger plugin version 2.18.3
Gerrit-Trigger plugin version 2.10.1 on Jenkins ver. 1.523
```
Contributor guide
Research direction
Start by reproducing the gerrit-trigger plugin failure with the commit message `Remove 'Custom' mode from "Connection Settings"` and observe the Maven call it triggers. Compare the behavior with the same message after removing the single quotes. Done means the triggered job runs successfully while preserving the commit message content.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100