jenkinsci / jenkinsci/ec2-plugin
[JENKINS-57513] Split the large databound constructors into databound setters
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 292
- Forks
- 709
- Avg merge
- 3d 16h
- Merged PRs (30d)
- 4
Description
Inside EC2 plugin there is a lot of constructors with a large set of databound constructors.
Databound constructor should only be used for mandatory/final parameters
Where databound setters should be used for optional parameters.
https://jenkins.io/doc/developer/plugin-development/pipeline-integration/#constructor-vs-setters
---
Originally reported by
casz, imported from: Split the large databound constructors into databound setters
Raw content of original issue
Inside EC2 plugin there is a lot of constructors with a large set of databound constructors.
Databound constructor should only be used for mandatory/final parametersWhere databound setters should be used for optional parameters.
https://jenkins.io/doc/developer/plugin-development/pipeline-integration/#constructor-vs-setters
1 attachment
- [ec2-slave-template-2020-03-16 092547.png](https://issues.jenkins.io/secure/attachment/50685/ec2-slave-template-2020-03-16%20092547.png)
> 
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the EC2 plugin classes with large databound constructors and review the linked Jenkins constructor-versus-setters guidance first. The work is done when optional parameters use databound setters while mandatory or final parameters remain in constructors, with existing behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, java
- Domain
- backend, cloud
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100