jenkinsci / jenkinsci/docker-workflow-plugin
[JENKINS-41474] docker.inside to rely on runC
- Dominant language
- Java
- Stars
- 527
- Forks
- 422
- Avg merge
- 10m
- Merged PRs (30d)
- 1
Description
docker.inside does a bind mount of the workspace, assuming the docker daemon is a local one. If we admit this assumption, then we should better rely on runC (docker 1.11 and later) that allows to exec inside a container with support for --env and --cwd, two options that `docker exec` doesn't support (and won't support, according to docker roadmap)
This would allow to avoid relying on `env` hack (https://github.com/jenkinsci/docker-workflow-plugin/blob/master/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java#L225) and fix JENKINS-33510
---
Originally reported by
ndeloof, imported from: docker.inside to rely on runC
Raw content of original issue
docker.inside does a bind mount of the workspace, assuming the docker daemon is a local one. If we admit this assumption, then we should better rely on runC (docker 1.11 and later) that allows to exec inside a container with support for --env and --cwd, two options that `docker exec` doesn't support (and won't support, according to docker roadmap)
This would allow to avoid relying on `env` hack (https://github.com/jenkinsci/docker-workflow-plugin/blob/master/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java#L225) and fix
JENKINS-33510
Contributor guide
Assessment
This issue has not been assessed yet.