jenkinsci / jenkinsci/docker-plugin

Deprecated value in DEFAULT_ENTRY_POINT_ARGUMENTS

Open
#1,060 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
498
Forks
324
Avg merge
1d 2h
Merged PRs (30d)
2

Description

### Jenkins and plugins versions report

Environment


```text

```
Since Remoting [3192.v713e3b_039fb_e](https://github.com/jenkinsci/remoting/releases/tag/3192.v713e3b_039fb_e), using positional arguments is deprecated. The documentation of inboud-agent indicate the new parameters [here](https://github.com/jenkinsci/remoting/blob/master/docs/inbound-agent.md#run-from-command-line)
Using latest Jenkins LTS (2.440.2) and latest Remoting, the agent log reports :
```log
WARNING: Providing the secret and agent name as positional arguments is deprecated; use "-secret" and "-name" instead.
```

It seems that this is [line](https://github.com/jenkinsci/docker-plugin/blob/master/src/main/java/io/jenkins/docker/connector/DockerComputerJNLPConnector.java#L170C33-L170C62) to modify to fix the warning.

### What Operating System are you using (both controller, and any agents involved in the problem)?

Remoting agent since [3192.v713e3b_039fb_e](https://github.com/jenkinsci/remoting/releases/tag/3192.v713e3b_039fb_e)
Latest Jenkins LTS (2.440.2)
Latest Docker Plugin (1.6)

### Reproduction steps

Use latest LTS Jenkins as controller
Use latest Remoting in docker agent
Review log of agent when is started

### Expected Results

```json
"Cmd": [
"-url",
"https://jenkins-srv.com/jenkins",
"-secret",
"2bef635d010fc86b695f2c25c6c133d026f651c0034b44f920c25e118716c2fc",
"-name",
"docker-0000pvexzrh7f"
],
```

### Actual Results

```json
"Cmd": [
"-url",
"https://jenkins-srv.com/jenkins",
"2bef635d010fc86b695f2c25c6c133d026f651c0034b44f920c25e118716c2fc",
"docker-0000pvexzrh7f"
],
```

### Anything else?

_No response_

### Are you interested in contributing a fix?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.